Sheernox
New Member
Env: ClientExec 7.3.0 (ionCube), PHP 8.5.12, MariaDB 11.8.9.
Where: verifytwofactorAction (fuse=admin&action=verifytwofactor, encoded), posted by templates/default/views/home/indexpublic/twofactor.phtml
Bug: If the two-factor form is posted twice before the first reply arrives (Enter pressed twice, or a password manager's auto-submit followed by the user's Enter), the first post signs in and replaces the session hash. The browser abandons that reply, including its new session cookie, and the second post arrives with the old hash. ClientExec logs "Possible Security Issue - Action (verifytwofactor) called without proper hash" and ends the session, so the user is back at the sign-in page although the event log records a successful login. The overlay blocks a second click on Verify but not a second Enter.
Repro:
Fix: Ignore a repeated post of a form that has already been posted, or have verifytwofactor redirect a session that is already fully signed in to its dashboard instead of treating the stale hash as an attack.
Where: verifytwofactorAction (fuse=admin&action=verifytwofactor, encoded), posted by templates/default/views/home/indexpublic/twofactor.phtml
Bug: If the two-factor form is posted twice before the first reply arrives (Enter pressed twice, or a password manager's auto-submit followed by the user's Enter), the first post signs in and replaces the session hash. The browser abandons that reply, including its new session cookie, and the second post arrives with the old hash. ClientExec logs "Possible Security Issue - Action (verifytwofactor) called without proper hash" and ends the session, so the user is back at the sign-in page although the event log records a successful login. The overlay blocks a second click on Verify but not a second Enter.
Repro:
- Turn on two-factor for a staff account and sign in with its password.
- On the two-factor page (default template), type the code and press Enter twice, about 300 ms apart.
- The browser lands signed out on index.php. The event log shows Successful Admin Login and, in the same second, the Security Alert above.
Fix: Ignore a repeated post of a form that has already been posted, or have verifytwofactor redirect a session that is already fully signed in to its dashboard instead of treating the stale hash as an attack.