Sheernox
New Member
Env: ClientExec 7.3.0 stable (ionCube), PHP 8.5.12, MariaDB 11.8.9. Found on our staging install, 2026-11-17.
Where:
Bug: The posted addonQuantity value for an addon is cast to an integer and only floored at 0. There is no upper bound and no per-addon maximum setting, so a client can order any quantity of an addon that allows quantities; the quantity field's limit exists only in the order form's markup. The price is calculated correctly for the quantity posted, so this is a limits problem (for example 500 mailboxes or IP addresses on one package), not a pricing one.
Repro:
Fix: A per-addon maximum quantity setting, enforced in verifyAddonQuantity (clamp or refuse above it), alongside the existing floor at 0.
Where:
modules/admin/models/ActiveOrderGateway.php lines 4920-4933, verifyAddonQuantity, used for the cart (2194) and for the order's invoice lines (4605).Bug: The posted addonQuantity value for an addon is cast to an integer and only floored at 0. There is no upper bound and no per-addon maximum setting, so a client can order any quantity of an addon that allows quantities; the quantity field's limit exists only in the order form's markup. The price is calculated correctly for the quantity posted, so this is a limits problem (for example 500 mailboxes or IP addresses on one package), not a pricing one.
Repro:
- On an order form, choose a product with an addon that allows a quantity.
- Post the configure step with the addon's quantity field set to 500.
- The cart and checkout price and accept 500 of the addon.
Fix: A per-addon maximum quantity setting, enforced in verifyAddonQuantity (clamp or refuse above it), alongside the existing floor at 0.